<html>
<head><meta charset="utf-8"><title>It it ok to remove -Zincremental-info? · t-compiler/help · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/index.html">t-compiler/help</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/It.20it.20ok.20to.20remove.20-Zincremental-info.3F.html">It it ok to remove -Zincremental-info?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="212916015"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/It%20it%20ok%20to%20remove%20-Zincremental-info%3F/near/212916015" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/It.20it.20ok.20to.20remove.20-Zincremental-info.3F.html#212916015">(Oct 10 2020 at 13:24)</a>:</h4>
<p>I am working on some cleanup of the CodegenBackend interface. I noticed that the support for <code>-Zincremental-info</code> is commented out (<a href="https://github.com/rust-lang/rust/blob/97eb606e4b2becd17d46a67d87169f52b210e67c/compiler/rustc_codegen_ssa/src/back/write.rs#L662">https://github.com/rust-lang/rust/blob/97eb606e4b2becd17d46a67d87169f52b210e67c/compiler/rustc_codegen_ssa/src/back/write.rs#L662</a>). Can I completely remove it, or should I keep it for when it will be fixed again?</p>



<a name="212916045"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/It%20it%20ok%20to%20remove%20-Zincremental-info%3F/near/212916045" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/It.20it.20ok.20to.20remove.20-Zincremental-info.3F.html#212916045">(Oct 10 2020 at 13:25)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="124287">@mw</span></p>



<a name="212916458"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/It%20it%20ok%20to%20remove%20-Zincremental-info%3F/near/212916458" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/It.20it.20ok.20to.20remove.20-Zincremental-info.3F.html#212916458">(Oct 10 2020 at 13:32)</a>:</h4>
<p>Another thing: Should <code>llvm_util::time_trace_profiler_finish</code> really be called after <code>link_binary</code>, or it it ok to move it in front? I don't know if <code>LlvmArchiveBuilder</code> gets included in the llvm profile.</p>



<a name="212918276"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/It%20it%20ok%20to%20remove%20-Zincremental-info%3F/near/212918276" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/It.20it.20ok.20to.20remove.20-Zincremental-info.3F.html#212918276">(Oct 10 2020 at 14:21)</a>:</h4>
<p>I moved it.</p>



<a name="213009027"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/It%20it%20ok%20to%20remove%20-Zincremental-info%3F/near/213009027" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/It.20it.20ok.20to.20remove.20-Zincremental-info.3F.html#213009027">(Oct 12 2020 at 08:11)</a>:</h4>
<p>Yes, I think <code>-Zincremental-info</code> can be removed. We already have something better based on <code>-Zself-profile</code></p>



<a name="213011061"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/It%20it%20ok%20to%20remove%20-Zincremental-info%3F/near/213011061" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/It.20it.20ok.20to.20remove.20-Zincremental-info.3F.html#213011061">(Oct 12 2020 at 08:35)</a>:</h4>
<p>I removed the mention in cg_llvm in the latest commit of <a href="https://github.com/rust-lang/rust/issues/77795">#77795</a>. There are still several other mentions of <code>-Zincremental-info</code> though. Should I remove those too?</p>



<a name="213011284"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/182449-t-compiler/help/topic/It%20it%20ok%20to%20remove%20-Zincremental-info%3F/near/213011284" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> bjorn3 <a href="https://rust-lang.github.io/zulip_archive/stream/182449-t-compiler/help/topic/It.20it.20ok.20to.20remove.20-Zincremental-info.3F.html#213011284">(Oct 12 2020 at 08:38)</a>:</h4>
<p>The other uses seem to mostly be printing debug messages why (part of) the incremental cache was ignored.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>